Skip to content

Revert "update SpeziStudy (#29)"#31

Merged
lukaskollmer merged 1 commit into
mainfrom
lukas/sorry
May 13, 2026
Merged

Revert "update SpeziStudy (#29)"#31
lukaskollmer merged 1 commit into
mainfrom
lukas/sorry

Conversation

@lukaskollmer

@lukaskollmer lukaskollmer commented May 13, 2026

Copy link
Copy Markdown
Collaborator

This reverts commit 467af81.

Revert "update SpeziStudy (#29)"

♻️ Current situation & Problem

i messed up the releases

⚙️ Release Notes

📚 Documentation

n/a

✅ Testing

n/a

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@lukaskollmer lukaskollmer self-assigned this May 13, 2026
@lukaskollmer lukaskollmer added the enhancement New feature or request label May 13, 2026
@coderabbitai

coderabbitai Bot commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bb8101d9-645e-40c0-878c-ea2b4a6af5d7

📥 Commits

Reviewing files that changed from the base of the PR and between 467af81 and a4e7e29.

📒 Files selected for processing (2)
  • Package.swift
  • Sources/MHCStudyDefinitionExporter/Study.swift
📝 Walkthrough

Walkthrough

This PR downgrades dependencies on SpeziFoundation and SpeziStudy packages, applies MainActor concurrency isolation to two build targets, and removes localization infrastructure from the study definition metadata by replacing localized dictionary fields with scalar string values while decrementing the study revision.

Changes

Dependency Downgrade and Study De-localization

Layer / File(s) Summary
Dependency Versions and Build Isolation Configuration
Package.swift		 SpeziFoundation downgraded to 2.4.0, SpeziStudy downgraded to 0.1.19 with reordered dependency entries. MainActor default isolation added to both MHCStudyDefinitionExporter and MHCStudyDefinitionExporterCLI targets.
Study Definition De-localization
Sources/MHCStudyDefinitionExporter/Study.swift		 SpeziLocalization import removed. Study revision decremented to 38. Metadata fields (title, shortTitle, explanationText, shortExplanationText) changed from localized/dictionary syntax to scalar string values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • PSchmiedmayer
  • PaulGoldschmidt
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: reverting a previous commit. It is concise and directly related to the changeset.
Description check ✅ Passed The description is related to the changeset by explaining the revert action and providing context about why it was needed. It includes relevant details like the commit hash and release notes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lukas/sorry

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lukaskollmer lukaskollmer enabled auto-merge (squash) May 13, 2026 20:16
@lukaskollmer lukaskollmer merged commit 91eab4b into main May 13, 2026
4 of 5 checks passed
@lukaskollmer lukaskollmer deleted the lukas/sorry branch May 13, 2026 20:16
@github-project-automation github-project-automation Bot moved this from In Progress to Done in MyHeart Counts Project Planning May 13, 2026
@coderabbitai coderabbitai Bot mentioned this pull request May 23, 2026
Open
1 task
@coderabbitai coderabbitai Bot mentioned this pull request Jun 24, 2026
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PSchmiedmayer PSchmiedmayer PSchmiedmayer approved these changes

Assignees

@lukaskollmer lukaskollmer

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukaskollmer @PSchmiedmayer